[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240719175722.000016f8@Huawei.com>
Date: Fri, 19 Jul 2024 17:57:22 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Mike Rapoport <rppt@...nel.org>
CC: <linux-kernel@...r.kernel.org>, Alexander Gordeev
<agordeev@...ux.ibm.com>, Andreas Larsson <andreas@...sler.com>, "Andrew
Morton" <akpm@...ux-foundation.org>, Arnd Bergmann <arnd@...db.de>, "Borislav
Petkov" <bp@...en8.de>, Catalin Marinas <catalin.marinas@....com>, Christophe
Leroy <christophe.leroy@...roup.eu>, Dan Williams <dan.j.williams@...el.com>,
Dave Hansen <dave.hansen@...ux.intel.com>, David Hildenbrand
<david@...hat.com>, "David S. Miller" <davem@...emloft.net>, Greg
Kroah-Hartman <gregkh@...uxfoundation.org>, Heiko Carstens
<hca@...ux.ibm.com>, Huacai Chen <chenhuacai@...nel.org>, Ingo Molnar
<mingo@...hat.com>, Jiaxun Yang <jiaxun.yang@...goat.com>, "John Paul Adrian
Glaubitz" <glaubitz@...sik.fu-berlin.de>, Michael Ellerman
<mpe@...erman.id.au>, Palmer Dabbelt <palmer@...belt.com>, "Rafael J.
Wysocki" <rafael@...nel.org>, Rob Herring <robh@...nel.org>, "Thomas
Bogendoerfer" <tsbogend@...ha.franken.de>, Thomas Gleixner
<tglx@...utronix.de>, Vasily Gorbik <gor@...ux.ibm.com>, Will Deacon
<will@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
<loongarch@...ts.linux.dev>, <linux-mips@...r.kernel.org>,
<linuxppc-dev@...ts.ozlabs.org>, <linux-riscv@...ts.infradead.org>,
<linux-s390@...r.kernel.org>, <linux-sh@...r.kernel.org>,
<sparclinux@...r.kernel.org>, <linux-acpi@...r.kernel.org>,
<linux-cxl@...r.kernel.org>, <nvdimm@...ts.linux.dev>,
<devicetree@...r.kernel.org>, <linux-arch@...r.kernel.org>,
<linux-mm@...ck.org>, <x86@...nel.org>
Subject: Re: [PATCH 11/17] x86/numa: numa_{add,remove}_cpu: make cpu
parameter unsigned
On Tue, 16 Jul 2024 14:13:40 +0300
Mike Rapoport <rppt@...nel.org> wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@...nel.org>
>
> CPU id cannot be negative.
>
> Making it unsigned also aligns with declarations in
> include/asm-generic/numa.h used by arm64 and riscv and allows sharing
> numa emulation code with these architectures.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
Makes sense for both reasons. FWIW given how simple it is.
Maybe worth bringing a few more functions inline with this?
Probably something for another day given we don't care about the
inconsistency for this series.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Powered by blists - more mailing lists