linux-kernel - Re: [PATCH] arm: kprobes: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <05cacd03-686a-4ede-b485-7f4781f69b99@app.fastmail.com>
Date: Fri, 19 Jul 2024 13:28:45 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Jeff Johnson" <quic_jjohnson@...cinc.com>,
 "Russell King" <linux@...linux.org.uk>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] arm: kprobes: add missing MODULE_DESCRIPTION() macro

On Tue, Jul 9, 2024, at 21:53, Jeff Johnson wrote:
> On 6/22/2024 9:34 PM, Jeff Johnson wrote:
>> With ARCH=arm, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o
>> 
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>> 
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
>> ---
>>  arch/arm/probes/kprobes/test-core.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c
>> index 171c7076b89f..6e9041a76b8b 100644
>> --- a/arch/arm/probes/kprobes/test-core.c
>> +++ b/arch/arm/probes/kprobes/test-core.c
>> @@ -1664,6 +1664,7 @@ static void __exit kprobe_test_exit(void)
>>  
>>  module_init(run_all_tests)
>>  module_exit(kprobe_test_exit)
>> +MODULE_DESCRIPTION("ARM kprobes test module");
>>  MODULE_LICENSE("GPL");
>>  
>>  #else /* !MODULE */
>> 
>> ---
>> base-commit: 563a50672d8a86ec4b114a4a2f44d6e7ff855f5b
>> change-id: 20240622-md-arm-arch-arm-probes-kprobes-34037098a2c3
>
> I don't see this in linux-next yet so following up to see if anything else is
> needed to get this merged.

Hi Jeff,

The arm tree uses a separate submission system for reviewed
patches to get into the tree, see

https://www.arm.linux.org.uk/developer/patches/info.php
https://www.arm.linux.org.uk/developer/patches/section.php?section=0

I looked at this file as well during build testing
and ended up combining the change with a cleanup,
If you like, I can send my version instead, see below.

      Arnd

diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c
index 171c7076b89f..0c6639509eff 100644
--- a/arch/arm/probes/kprobes/test-core.c
+++ b/arch/arm/probes/kprobes/test-core.c
@@ -1650,24 +1650,16 @@ static int __init run_all_tests(void)
 
 	return ret;
 }
-
+late_initcall(run_all_tests);
 
 /*
  * Module setup
  */
 
-#ifdef MODULE
-
 static void __exit kprobe_test_exit(void)
 {
 }
-
-module_init(run_all_tests)
 module_exit(kprobe_test_exit)
-MODULE_LICENSE("GPL");
 
-#else /* !MODULE */
-
-late_initcall(run_all_tests);
-
-#endif
+MODULE_DESCRIPTION("Test code for ARM kprobes");
+MODULE_LICENSE("GPL");