[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240719135515.GB637@pendragon.ideasonboard.com>
Date: Fri, 19 Jul 2024 16:55:15 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-pwm@...r.kernel.org,
Bartosz Golaszewski <brgl@...ev.pl>,
Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Lee Jones <lee@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Rob Herring <robh@...nel.org>,
Uwe Kleine-König <ukleinek@...nel.org>,
Haibo Chen <haibo.chen@....com>
Subject: Re: [PATCH v4 3/4] gpio: adp5585: Add Analog Devices ADP5585 support
Hello Andy,
On Mon, Jun 10, 2024 at 07:29:09PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 10, 2024 at 6:26 PM Laurent Pinchart wrote:
> > On Mon, Jun 10, 2024 at 06:15:40PM +0300, Andy Shevchenko wrote:
> > > Sat, Jun 08, 2024 at 05:16:32PM +0300, Laurent Pinchart kirjoitti:
>
> ...
>
> > > > +static const struct platform_device_id adp5585_gpio_id_table[] = {
> > > > + { "adp5585-gpio" },
> > >
> > > > + { /* Sentinel */ },
> > >
> > > Drop the comma.
> >
> > I prefer keeping it.
>
> For what reason?
> The sentinel should be runtime and compile time one. Why should we
> make our lives worse by neglecting help from a compiler?
Do you really think there's a risk here and that this will make a
difference ? I do appreciate most of your review comments, even
pendantic ones, as they can help making the code better, but we also all
need a little bit of space to breathe when it comes to coding style.
> > > > +};
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists