linux-kernel - Re: [PATCH v4 4/4] pwm: adp5585: Add Analog Devices ADP5585 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240719140711.GC637@pendragon.ideasonboard.com>
Date: Fri, 19 Jul 2024 17:07:11 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-pwm@...r.kernel.org,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Conor Dooley <conor+dt@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Lee Jones <lee@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Uwe Kleine-König <ukleinek@...nel.org>,
	Clark Wang <xiaoning.wang@....com>, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v4 4/4] pwm: adp5585: Add Analog Devices ADP5585 support

Hi Andy,

(CC'ing Mark)

On Mon, Jun 10, 2024 at 07:31:11PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 10, 2024 at 6:28 PM Laurent Pinchart wrote:
> > On Mon, Jun 10, 2024 at 06:06:51PM +0300, Andy Shevchenko wrote:
> > > Sat, Jun 08, 2024 at 05:16:33PM +0300, Laurent Pinchart kirjoitti:
> 
> ...
> 
> > Andy, we're reaching a level of nitpicking and yakshaving that even I
> > can't deal with. I will have to simply ignore the comments I disagree
> > with.
> 
> Do you think using bulk APIs is nit-picking?

In this case I do. If we were dealing with more 16-bit registers in this
driver I would agree with you. This being said, I'd like to get this
driver merged, and I'll burn some of the mental energy I've recovered
thanks to the last two weeks of holidays and submit a v5 using the bulk
API. It's getting mentally exhausting though.

Overall, I think it would be nice to improve support for variable-length
register maps, in a similar way as done in include/media/v4l2-cci.h.
This driver, as well as many other drivers, could really benefit from
it. Mark, do you have an opinion, is v4l2-cci something that we could
fold in regmap itself ?

-- 
Regards,

Laurent Pinchart