linux-kernel - Re: [PATCH 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a419902-f45e-45bc-bd9c-3b3e434f9e7a@web.de>
Date: Fri, 19 Jul 2024 21:42:43 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: George Yang <George.Yang@....com>, Lizhi Hou <lizhi.hou@....com>,
 Min Ma <min.ma@....com>, Narendra Gutta
 <VenkataNarendraKumar.Gutta@....com>, dri-devel@...ts.freedesktop.org,
 Oded Gabbay <ogabbay@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Max Zhen <max.zhen@....com>,
 Sonal Santan <sonal.santan@....com>
Subject: Re: [PATCH 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

…
> +++ b/drivers/accel/amdxdna/amdxdna_pci_drv.c
> @@ -0,0 +1,118 @@
…
> +static int amdxdna_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> +{
…
> +	mutex_lock(&xdna->dev_lock);
> +	ret = xdna->dev_info->ops->init(xdna);
> +	mutex_unlock(&xdna->dev_lock);
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&xdna->dev_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc5/source/include/linux/mutex.h#L196

Regards,
Markus