linux-kernel - Re: [PATCH v8 2/2] iio: light: ROHM BH1745 colour sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28b3a7e1-5242-4c73-9033-d69582eee73a@gmail.com>
Date: Sat, 20 Jul 2024 19:25:48 +0100
From: Mudit Sharma <muditsharma.info@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: lars@...afoo.de, krzk+dt@...nel.org, conor+dt@...nel.org,
 robh@...nel.org, linux-kernel@...r.kernel.org, mazziesaccount@...il.com,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 Ivan Orlov <ivan.orlov0322@...il.com>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>
Subject: Re: [PATCH v8 2/2] iio: light: ROHM BH1745 colour sensor

On 20/07/2024 17:29, Jonathan Cameron wrote:
> On Thu, 18 Jul 2024 23:02:06 +0100
> Mudit Sharma <muditsharma.info@...il.com> wrote:
> 
>> Add support for BH1745, which is an I2C colour sensor with red, green,
>> blue and clear channels. It has a programmable active low interrupt
>> pin. Interrupt occurs when the signal from the selected interrupt
>> source channel crosses set interrupt threshold high or low level.
>>
>> Interrupt source for the device can be configured by enabling the
>> corresponding event. Interrupt latch is always enabled when setting
>> up interrupt.
>>
>> Add myself as the maintainer for this driver in MAINTAINERS.
>>
>> Signed-off-by: Mudit Sharma <muditsharma.info@...il.com>
>> Reviewed-by: Ivan Orlov <ivan.orlov0322@...il.com>
>> Reviewed-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> 
> Hi Mudit.
> 
> Rather than go around again, I've applied a few things I noticed
> and changes Javier suggests whilst picking this up.

Hi Jonathan,

Thank you for reviewing and applying the changes.
> 
> I also tweaked a few long lines.
> 
> Anyhow, applied to the testing branch of iio.git which will be rebased
> on rc1 once available and pushed out as togreg for linux-next to
> pick up.
> 
> Thanks,
> 
> Jonathan
> 
> 
>> +
>> +	i2c_set_clientdata(client, indio_dev);
> Trivial, but is this ever used?  I couldn't figure out where it if is.
> So I've dropped it. Shout if it needs to be here.
> 
This isn't used and can be dropped.

Thank you.

Best regards,
Mudit Sharma