linux-kernel - Re: [PATCH v8 2/2] iio: light: ROHM BH1745 colour sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbefce0e-e5f9-400c-a387-f60609f5bba3@gmail.com>
Date: Sat, 20 Jul 2024 19:29:28 +0100
From: Mudit Sharma <muditsharma.info@...il.com>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>, jic23@...nel.org,
 lars@...afoo.de, krzk+dt@...nel.org, conor+dt@...nel.org, robh@...nel.org
Cc: linux-kernel@...r.kernel.org, mazziesaccount@...il.com,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 Ivan Orlov <ivan.orlov0322@...il.com>
Subject: Re: [PATCH v8 2/2] iio: light: ROHM BH1745 colour sensor

On 19/07/2024 17:02, Javier Carrasco wrote:
> On 19/07/2024 00:02, Mudit Sharma wrote:
>> Add support for BH1745, which is an I2C colour sensor with red, green,
>> blue and clear channels. It has a programmable active low interrupt
>> pin. Interrupt occurs when the signal from the selected interrupt
>> source channel crosses set interrupt threshold high or low level.
>>
>> Interrupt source for the device can be configured by enabling the
>> corresponding event. Interrupt latch is always enabled when setting
>> up interrupt.
>>
>> Add myself as the maintainer for this driver in MAINTAINERS.
>>
>> Signed-off-by: Mudit Sharma <muditsharma.info@...il.com>
>> Reviewed-by: Ivan Orlov <ivan.orlov0322@...il.com>
>> Reviewed-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> 
> Hi Mudit,
> 
> a couple of nitpicks inline.
> 
> ...
> 
> 
> Typo in debug message: corresponding. I would recommend you to pass
> codespell to checkpatch. It will often catch such things.
> 
Hi Javier,

Thank you for reviewing and the recommendation. Will keep in mind for 
future patches.

Best regards,
Mudit Sharma
>> +		dev_dbg(dev, "No corrosponding gain for requested integration time\n");
>> +		return ret;
>> +	}
>> +