linux-kernel - Re: [RFC PATCH 3/3] ARM: dts: davinci, keystone: correct watchdog nodenames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0e36e05-f565-48ad-9309-854b6fb7985c@kernel.org>
Date: Mon, 22 Jul 2024 10:13:59 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kousik Sanagavarapu <five231003@...il.com>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Wim Van Sebroeck <wim@...ux-watchdog.org>,
 Guenter Roeck <linux@...ck-us.net>, Nishanth Menon <nm@...com>,
 Santosh Shilimkar <ssantosh@...nel.org>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 3/3] ARM: dts: davinci, keystone: correct watchdog
 nodenames

On 21/07/2024 18:28, Kousik Sanagavarapu wrote:
> Using "wdt" instead of "watchdog" for watchdog timer nodes doesn't allow
> for validation with the corresponding dtschema and gives errors
> 
> 	$ make CHECK_DTBS=y DT_SCHEMA_FILES=ti,davinci-wdt.yaml \
> 		ti/keystone/keystone-k2g-ice.dtb
> 
> 	DTC_CHK arch/arm/boot/dts/ti/keystone/keystone-k2g-ice.dtb
> 	arch/arm/boot/dts/ti/keystone/keystone-k2g-ice.dtb:
> 	wdt@...50000: $nodename:0: 'wdt@...50000' does not match
> 	'^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$'
> 	from schema $id:
> 	http://devicetree.org/schemas/watchdog/ti,davinci-wdt.yaml#
> 
> Therefore change "wdt@" to "watchdog@".
> 
> While at it, remove "ti,davinci-wdt" compatible from the keystone dts
> code.

That's entirely unrelated patch. Don't mix simple cleanups with patches
affecting ABI and users. Also, explain why.

> 
> Signed-off-by: Kousik Sanagavarapu <five231003@...il.com>
> ---


Best regards,
Krzysztof