linux-kernel - Re: [PATCH 1/3] dt-bindings: timer: ti,davinci-timer: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90413248-8849-4533-93c9-3a976aad0295@kernel.org>
Date: Mon, 22 Jul 2024 10:11:45 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kousik Sanagavarapu <five231003@...il.com>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Wim Van Sebroeck <wim@...ux-watchdog.org>,
 Guenter Roeck <linux@...ck-us.net>, Nishanth Menon <nm@...com>,
 Santosh Shilimkar <ssantosh@...nel.org>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: timer: ti,davinci-timer: convert to
 dtschema

On 21/07/2024 18:28, Kousik Sanagavarapu wrote:
> Convert txt binding of TI's DaVinci timer to dtschema to allow for
> validation.
> 


> diff --git a/Documentation/devicetree/bindings/timer/ti,davinci-timer.yaml b/Documentation/devicetree/bindings/timer/ti,davinci-timer.yaml
> new file mode 100644
> index 000000000000..615ceb8f30af
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/ti,davinci-timer.yaml

Use compatible as filename.

> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/ti,davinci-timer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI DaVinci Timer
> +
> +maintainers:
> +  - Kousik Sanagavarapu <five231003@...il.com>
> +
> +description: |
> +

Drop blank line

> +  This is a 64-bit timer found on TI's DaVinci architecture devices. The timer
> +  can be configured as a general-purpose 64-bit timer, dual general-purpose
> +  32-bit timers. When configured as dual 32-bit timers, each half can operate
> +  in conjunction (chain mode) or independently (unchained mode) of each other.
> +
> +  The timer is a free running up-counter and can generate interrupts when the
> +  counter reaches preset counter values.
> +
> +properties:
> +  compatible:
> +    const: ti,da830-timer
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    minItems: 2

Missing maxItems

> +
> +  interrupt-names:
> +    minItems: 2
> +    items:
> +      - const: tint12
> +      - const: tint34
> +      - const: cmpint0
> +      - const: cmpint1
> +      - const: cmpint2
> +      - const: cmpint3
> +      - const: cmpint4
> +      - const: cmpint5
> +      - const: cmpint6
> +      - const: cmpint7

Best regards,
Krzysztof