linux-kernel - Re: [PATCH] ASoC: sti: add missing probe entry for player and reader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d85590f2-88b3-4bc2-b7b8-9f96a5d5bb17@sirena.org.uk>
Date: Mon, 22 Jul 2024 11:52:44 +0100
From: Mark Brown <broonie@...nel.org>
To: Jerome Audu <jau@...e.fr>
Cc: Arnaud Pouliquen <arnaud.pouliquen@...s.st.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	alsa-devel@...a-project.org, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: sti: add missing probe entry for player and reader

On Sun, Jul 21, 2024 at 05:40:02PM +0200, Jerome Audu wrote:
> Restores the audio functionality that was broken
> since Linux version 6.6.y by adding the missing probe
> functions for the player and reader components.
> 
> Fixes: 9f625f5e6cf9 ("ASoC: sti: merge DAI call back functions into ops")
> Signed-off-by: Jerome Audu <jau@...e.fr>
> ---
> Specifically, the probe function in `sound/soc/sti/sti_uniperif.c:415` is being replaced by another probe function located at `sound/soc/sti/sti_uniperif.c:453`, which should instead be derived from the player and reader components. My patch correctly reinserts the missing probe entries, restoring the intended functionality.

This should be in the changelog, your actual changelog doesn't describe
the actual change at all.

> The patch modifies the following files:
> - `sound/soc/sti/sti_uniperif.c`: Changes the visibility of `sti_uniperiph_dai_probe` to non-static.
> - `sound/soc/sti/uniperif.h`: Adds the declaration of `sti_uniperiph_dai_probe`.
> - `sound/soc/sti/uniperif_player.c`: Adds `probe` function to `uni_player_dai_ops`.
> - `sound/soc/sti/uniperif_reader.c`: Adds `probe` function to `uni_reader_dai_ops`.
> 
> This ensures the correct `probe` functions are utilized, thus fixing the audio regression. 

This detail isn't really needed, it just describes the content of the
patch.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)