linux-kernel - Re: [PATCH] ASoC: sti: add missing probe entry for player and reader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1474761635.17820466.1721651484902.JavaMail.root@zimbra60-e10.priv.proxad.net>
Date: Mon, 22 Jul 2024 14:31:24 +0200 (CEST)
From: jau@...e.fr
To: Mark Brown <broonie@...nel.org>
Cc: Arnaud Pouliquen <arnaud.pouliquen@...s.st.com>, 
	Liam Girdwood <lgirdwood@...il.com>, 
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	alsa-devel@...a-project.org, linux-sound@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: sti: add missing probe entry for player and
 reader

Thanks for the review!

See updated changlog, if ok for you, I will send a V2

Le 22/07/2024 12:52, Mark Brown a écrit :
> This should be in the changelog, your actual changelog doesn't describe
> the actual change at all.
> 

New Changelog:

  This patch addresses a regression in the ASoC STI drivers that was introduced in Linux version 6.6.y.
  The issue originated from a series of patches (see https://lore.kernel.org/all/87wmy5b0wt.wl-kuninori.morimoto.gx@renesas.com/)
  that unintentionally omitted necessary probe functions for the player and reader components.

  Probe function in `sound/soc/sti/sti_uniperif.c:415` is being replaced by another probe function located at 
  `sound/soc/sti/sti_uniperif.c:453`, which should instead be derived from the player and reader components.
  This patch correctly reinserts the missing probe entries, restoring the intended functionality.

> This detail isn't really needed, it just describes the content of the
> patch.

ok, I remove this part.

Regards, 
Jérôme