linux-kernel - Re: [RFC PATCH v3 22/37] irqchip: Add kvx-core-intc core interrupt controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79eaca59-9ec3-424b-a2db-d27af72722d3@kernel.org>
Date: Mon, 22 Jul 2024 14:32:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: ysionneau@...rayinc.com, linux-kernel@...r.kernel.org,
 Thomas Gleixner <tglx@...utronix.de>
Cc: Jonathan Borne <jborne@...rayinc.com>,
 Julian Vetter <jvetter@...rayinc.com>,
 Clement Leger <clement@...ment-leger.fr>,
 Vincent Chardon <vincent.chardon@...ys-design.com>,
 Jules Maselbas <jmaselbas@...v.net>
Subject: Re: [RFC PATCH v3 22/37] irqchip: Add kvx-core-intc core interrupt
 controller driver

On 22/07/2024 11:41, ysionneau@...rayinc.com wrote:
> From: Yann Sionneau <ysionneau@...rayinc.com>
> 
> Each kvx core includes a hardware interrupt controller (core INTC)
> with the following features:
>  - 32 independent interrupt sources
>  - 4-bit priotity level
>  - Individual interrupt enable bit
>  - Interrupt status bit displaying the pending interrupts
>  - Priority management between the 32 interrupts


...

> +
> +static int __init
> +kvx_init_core_intc(struct device_node *intc, struct device_node *parent)
> +{
> +	uint32_t core_nr_irqs;
> +	unsigned long cpuid;
> +	int ret;
> +
> +	ret = kvx_of_parent_cpuid(intc, &cpuid);
> +	if (ret)
> +		panic("core intc has no CPU parent\n");
> +
> +	if (smp_processor_id() != cpuid) {
> +		fwnode_dev_initialized(of_fwnode_handle(intc), true);
> +		return 0;
> +	}
> +
> +	if (of_property_read_u32(intc, "kalray,intc-nr-irqs", &core_nr_irqs))

There is no such property. Stop adding fake properties to your code.



Best regards,
Krzysztof