linux-kernel - Re: [PATCH] mips: sibyte: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zp9gOOUp3ZWXY/B8@alpha.franken.de>
Date: Tue, 23 Jul 2024 09:48:08 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mips: sibyte: add missing MODULE_DESCRIPTION() macro

On Thu, Jul 18, 2024 at 04:17:52PM -0700, Jeff Johnson wrote:
> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
> description is missing"), a module without a MODULE_DESCRIPTION() will
> result in a warning with make W=1. The following warning is being
> observed when ARCH=mips and CONFIG_SIBYTE_TBPROF=m:
> 
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/mips/sibyte/common/sb_tbprof.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> ---
> I'm trying to fix all of these issues in 6.11, so please take this
> through your "for current" path instead of your "for next" path. If
> you don't have a "for current" path, Greg KH has indicated he'll pick
> up the stragglers before the 6.11 rc-final.
> ---
>  arch/mips/sibyte/common/sb_tbprof.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/sibyte/common/sb_tbprof.c b/arch/mips/sibyte/common/sb_tbprof.c
> index af5333986900..149a9151bc0b 100644
> --- a/arch/mips/sibyte/common/sb_tbprof.c
> +++ b/arch/mips/sibyte/common/sb_tbprof.c
> @@ -589,4 +589,5 @@ module_exit(sbprof_tb_cleanup);
>  
>  MODULE_ALIAS_CHARDEV_MAJOR(SBPROF_TB_MAJOR);
>  MODULE_AUTHOR("Ralf Baechle <ralf@...ux-mips.org>");
> +MODULE_DESCRIPTION("Support for ZBbus profiling");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: 51835949dda3783d4639cfa74ce13a3c9829de00
> change-id: 20240718-md-mips-arch-mips-sibyte-common-7c51d90b31f2

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]