linux-kernel - Re: [PATCH v3] Capitalized "c" to "C" and changed "expect" to "expected"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024072344-ripeness-ablaze-43bf@gregkh>
Date: Tue, 23 Jul 2024 09:48:03 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Steven Davis <goldside000@...look.com>
Cc: christian.gromm@...rochip.com, parthiban.veerasooran@...rochip.com,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Capitalized "c" to "C" and changed "expect" to
 "expected"

On Mon, Jul 22, 2024 at 12:59:44PM -0400, Steven Davis wrote:
> This patch makes three error messages in the driver easier to read by capitalizing the first letters properly.

Please wrap your changelog text at 72 characters, checkpatch should have
caught this, right?

> For example, "channel already linked" became "Channel already linked".
> In addition, "expect" becomes "expected", as you would typically find in an error message.

When you have "in addition" that usually means you should split this up
into different changes, rigth?

> This patch is necessary for improving user experience and the kernel's quality.

This isn't a quality thing, it's a "spelling fixes are nice" thing.

Also, please fix up the subject line to match those that have been made
to this file in the past with the correct prefix.

thanks,

greg k-h