[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dbfae024-c7ce-4311-9f7b-419aacc7e7d9@arm.com>
Date: Tue, 23 Jul 2024 09:26:56 +0100
From: Leo Yan <leo.yan@....com>
To: Adrian Hunter <adrian.hunter@...el.com>,
Peter Zijlstra <peterz@...radead.org>
Cc: Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Heiko Carstens <hca@...ux.ibm.com>, Thomas Richter <tmricht@...ux.ibm.com>,
Hendrik Brueckner <brueckner@...ux.ibm.com>,
Suzuki K Poulose <suzuki.poulose@....com>, Mike Leach
<mike.leach@...aro.org>, James Clark <james.clark@....com>,
coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
Yicong Yang <yangyicong@...ilicon.com>,
Jonathan Cameron <jonathan.cameron@...wei.com>, Will Deacon
<will@...nel.org>, Arnaldo Carvalho de Melo <acme@...nel.org>,
Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
Ian Rogers <irogers@...gle.com>, Andi Kleen <ak@...ux.intel.com>,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH V9 06/13] perf tools: Enable evsel__is_aux_event() to work
for S390_CPUMSF
On 7/15/2024 5:07 PM, Adrian Hunter wrote:
>
> evsel__is_aux_event() identifies AUX area tracing selected events.
>
> S390_CPUMSF uses a raw event type (PERF_TYPE_RAW - refer
> s390_cpumsf_evsel_is_auxtrace()) not a PMU type value that could be checked
> in evsel__is_aux_event(). However it sets needs_auxtrace_mmap (refer
> auxtrace_record__init()), so check that first.
>
> Currently, the features that use evsel__is_aux_event() are used only by
> Intel PT, but that may change in the future.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> Acked-by: Ian Rogers <irogers@...gle.com>
> Reviewed-by: Andi Kleen <ak@...ux.intel.com>
Reviewed-by: Leo Yan <leo.yan@....com>
> ---
> tools/perf/util/pmu.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 986166bc7c78..0b38c51bd6eb 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -1199,8 +1199,12 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu *pmu)
>
> bool evsel__is_aux_event(const struct evsel *evsel)
> {
> - struct perf_pmu *pmu = evsel__find_pmu(evsel);
> + struct perf_pmu *pmu;
>
> + if (evsel->needs_auxtrace_mmap)
> + return true;
> +
> + pmu = evsel__find_pmu(evsel);
> return pmu && pmu->auxtrace;
> }
>
> --
> 2.34.1
>
>
Powered by blists - more mailing lists