linux-kernel - Re: [PATCH V9 06/13] perf tools: Enable evsel__is_aux_event() to work for S390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb2433e2-d6a3-4d70-9b88-0047a9dd01d2@intel.com>
Date: Tue, 23 Jul 2024 12:09:46 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>
Cc: Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Heiko Carstens <hca@...ux.ibm.com>, Thomas Richter <tmricht@...ux.ibm.com>,
 Hendrik Brueckner <brueckner@...ux.ibm.com>,
 Suzuki K Poulose <suzuki.poulose@....com>, Mike Leach
 <mike.leach@...aro.org>, James Clark <james.clark@....com>,
 coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
 Yicong Yang <yangyicong@...ilicon.com>,
 Jonathan Cameron <jonathan.cameron@...wei.com>, Will Deacon
 <will@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
 Ian Rogers <irogers@...gle.com>, Andi Kleen <ak@...ux.intel.com>,
 linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
 Leo Yan <leo.yan@....com>, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH V9 06/13] perf tools: Enable evsel__is_aux_event() to work
 for S390_CPUMSF

On 23/07/24 11:26, Leo Yan wrote:
> On 7/15/2024 5:07 PM, Adrian Hunter wrote:
>>
>> evsel__is_aux_event() identifies AUX area tracing selected events.
>>
>> S390_CPUMSF uses a raw event type (PERF_TYPE_RAW - refer
>> s390_cpumsf_evsel_is_auxtrace()) not a PMU type value that could be checked
>> in evsel__is_aux_event(). However it sets needs_auxtrace_mmap (refer
>> auxtrace_record__init()), so check that first.
>>
>> Currently, the features that use evsel__is_aux_event() are used only by
>> Intel PT, but that may change in the future.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
>> Acked-by: Ian Rogers <irogers@...gle.com>
>> Reviewed-by: Andi Kleen <ak@...ux.intel.com>
> 
> Reviewed-by: Leo Yan <leo.yan@....com>

Namhyung, could we get patches 5 and 6 from this series
applied?  They are independent and Leo's new patch set is
dependent on patch 5.

> 
>> ---
>>  tools/perf/util/pmu.c | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
>> index 986166bc7c78..0b38c51bd6eb 100644
>> --- a/tools/perf/util/pmu.c
>> +++ b/tools/perf/util/pmu.c
>> @@ -1199,8 +1199,12 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu *pmu)
>>
>>  bool evsel__is_aux_event(const struct evsel *evsel)
>>  {
>> -       struct perf_pmu *pmu = evsel__find_pmu(evsel);
>> +       struct perf_pmu *pmu;
>>
>> +       if (evsel->needs_auxtrace_mmap)
>> +               return true;
>> +
>> +       pmu = evsel__find_pmu(evsel);
>>         return pmu && pmu->auxtrace;
>>  }
>>
>> --
>> 2.34.1
>>
>>