linux-kernel - Re: [PATCH v2 4/8] firmware: arm_scmi: Make MBOX transport a standalone driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR10MB46879DC8AB435367E0D3C251FDA92@PAXPR10MB4687.EURPRD10.PROD.OUTLOOK.COM>
Date: Tue, 23 Jul 2024 13:41:04 +0000
From: Etienne CARRIERE <etienne.carriere@...com>
To: Cristian Marussi <cristian.marussi@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "arm-scmi@...r.kernel.org"
	<arm-scmi@...r.kernel.org>
CC: "sudeep.holla@....com" <sudeep.holla@....com>,
        "james.quinlan@...adcom.com" <james.quinlan@...adcom.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "vincent.guittot@...aro.org"
	<vincent.guittot@...aro.org>,
        "peng.fan@....nxp.com" <peng.fan@....nxp.com>,
        "michal.simek@....com" <michal.simek@....com>,
        "quic_sibis@...cinc.com"
	<quic_sibis@...cinc.com>,
        "quic_nkela@...cinc.com" <quic_nkela@...cinc.com>,
        "ptosi@...gle.com" <ptosi@...gle.com>,
        "dan.carpenter@...aro.org"
	<dan.carpenter@...aro.org>,
        "souvik.chakravarty@....com"
	<souvik.chakravarty@....com>
Subject: Re: [PATCH v2 4/8] firmware: arm_scmi: Make MBOX transport a
 standalone driver

Hi Cristian,

On Wednesday, July 10, 2024, Cristian Marussi wrote:
> Make SCMI mailbox transport a standalne driver that can be optionally
> loaded as a module.
> 
> Signed-off-by: Cristian Marussi <cristian.marussi@....com>
> ---
>  drivers/firmware/arm_scmi/Kconfig             |  4 +-
>  drivers/firmware/arm_scmi/Makefile            |  3 +-
>  drivers/firmware/arm_scmi/common.h            |  3 --
>  drivers/firmware/arm_scmi/driver.c            |  3 --
>  .../{mailbox.c => scmi_transport_mailbox.c}   | 44 +++++++++++++------
>  5 files changed, 36 insertions(+), 21 deletions(-)
>  rename drivers/firmware/arm_scmi/{mailbox.c => scmi_transport_mailbox.c} (88%)
> 
> diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig
> index aa5842be19b2..135e34aefd70 100644
> --- a/drivers/firmware/arm_scmi/Kconfig
> +++ b/drivers/firmware/arm_scmi/Kconfig
> @@ -75,7 +75,7 @@ config ARM_SCMI_HAVE_MSG
>            available.
>  
>  config ARM_SCMI_TRANSPORT_MAILBOX
> -       bool "SCMI transport based on Mailbox"
> +       tristate "SCMI transport based on Mailbox"
>          depends on MAILBOX
>          select ARM_SCMI_HAVE_TRANSPORT
>          select ARM_SCMI_HAVE_SHMEM
> @@ -85,6 +85,8 @@ config ARM_SCMI_TRANSPORT_MAILBOX
>  
>            If you want the ARM SCMI PROTOCOL stack to include support for a
>            transport based on mailboxes, answer Y.
> +         This driver can also be built as a module.  If so, the module

Nitpicking: replace the 2 space char before "if so," with a single one?
Applies also to patch 5/8, 6/8 and 7/8.

Other wise LGTM , but my comment on patch 3/8 that would affect
use of DEFINE_SCMI_TRANSPORT_DRIVER() in patch 5 to 7.


br,
etienne

> +         will be called scmi_transport_mailbox.
>  
>  config ARM_SCMI_TRANSPORT_OPTEE
>          bool "SCMI transport based on OP-TEE service"
> (snip)