linux-kernel - Re: [PATCH v2 2/8] firmware: arm_scmi: Introduce packet handling helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR10MB4687B2FCCA6E59CAEF769713FDA92@PAXPR10MB4687.EURPRD10.PROD.OUTLOOK.COM>
Date: Tue, 23 Jul 2024 13:41:19 +0000
From: Etienne CARRIERE <etienne.carriere@...com>
To: Peng Fan <peng.fan@....com>, Cristian Marussi <cristian.marussi@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "arm-scmi@...r.kernel.org"
	<arm-scmi@...r.kernel.org>
CC: "sudeep.holla@....com" <sudeep.holla@....com>,
        "james.quinlan@...adcom.com" <james.quinlan@...adcom.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "vincent.guittot@...aro.org"
	<vincent.guittot@...aro.org>,
        "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "michal.simek@....com" <michal.simek@....com>,
        "quic_sibis@...cinc.com"
	<quic_sibis@...cinc.com>,
        "quic_nkela@...cinc.com" <quic_nkela@...cinc.com>,
        "ptosi@...gle.com" <ptosi@...gle.com>,
        "dan.carpenter@...aro.org"
	<dan.carpenter@...aro.org>,
        "souvik.chakravarty@....com"
	<souvik.chakravarty@....com>
Subject: Re: [PATCH v2 2/8] firmware: arm_scmi: Introduce packet handling
 helpers

Hi,

On Thursday, July 11, 2024, Peng Fan wrote:
> > Subject: [PATCH v2 2/8] firmware: arm_scmi: Introduce packet
> > handling helpers
> >
> > Introduce a pair of structures initialized to contain all the existing
> > packet handling helpers, both for transports based on shared memory
> > and messages.
> >
> > No functional change.
> >
> > Signed-off-by: Cristian Marussi <cristian.marussi@....com>
> > ---
> > v1 --> v2
> > - fixed commit message
> > ---
> ......
> 
> > d33a704e5814..f4ba38afe0bb 100644
> > --- a/drivers/firmware/arm_scmi/msg.c
> > +++ b/drivers/firmware/arm_scmi/msg.c
> > @@ -4,8 +4,8 @@
> >   *
> >   * Derived from shm.c.
> >   *
> > - * Copyright (C) 2019-2021 ARM Ltd.
> > - * Copyright (C) 2020-2021 OpenSynergy GmbH
> > + * Copyright (C) 2019-2024 ARM Ltd.
> > + * Copyright (C) 2020-2024 OpenSynergy GmbH
> 
> Nitpick: OpenSynergy year should be kept unchanged?

I agree. Copyright dates on original non-Arm contributors should
not be changed, here and in patch 5/8, 6/8 and 7/8.

> 
> Otherwise looks good:
> Reviewed-by: Peng Fan <peng.fan@....com>