linux-kernel - Re: [PATCH] tools/bpf:Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c99385c566bc2e58b641060a69d360a21944a65.camel@kernel.org>
Date: Wed, 24 Jul 2024 16:17:38 +0800
From: Geliang Tang <geliang@...nel.org>
To: Zhu Jun <zhujun2@...s.chinamobile.com>, qmo@...nel.org
Cc: ast@...nel.org, daniel@...earbox.net, martin.lau@...ux.dev,
 eddyz87@...il.com,  song@...nel.org, yonghong.song@...ux.dev,
 john.fastabend@...il.com,  kpsingh@...nel.org, sdf@...ichev.me,
 haoluo@...gle.com, bpf@...r.kernel.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/bpf:Fix the wrong format specifier

On Tue, 2024-07-23 at 23:42 -0700, Zhu Jun wrote:
> The unsigned int should use "%u" instead of "%d".

I guess you mean:

The format specifier of "unsigned int" in printf() should be "%u", not
"%d".

> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>

Acked-by: Geliang Tang <geliang@...nel.org>

> ---
>  tools/bpf/bpftool/xlated_dumper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/bpf/bpftool/xlated_dumper.c
> b/tools/bpf/bpftool/xlated_dumper.c
> index 567f56dfd9f1..3efa639434be 100644
> --- a/tools/bpf/bpftool/xlated_dumper.c
> +++ b/tools/bpf/bpftool/xlated_dumper.c
> @@ -349,7 +349,7 @@ void dump_xlated_plain(struct dump_data *dd, void
> *buf, unsigned int len,
>  
>  		double_insn = insn[i].code == (BPF_LD | BPF_IMM |
> BPF_DW);
>  
> -		printf("% 4d: ", i);
> +		printf("% 4u: ", i);
>  		print_bpf_insn(&cbs, insn + i, true);
>  
>  		if (opcodes) {
> @@ -415,7 +415,7 @@ void dump_xlated_for_graph(struct dump_data *dd,
> void *buf_start, void *buf_end,
>  			}
>  		}
>  
> -		printf("%d: ", insn_off);
> +		printf("%u: ", insn_off);
>  		print_bpf_insn(&cbs, cur, true);
>  
>  		if (opcodes) {