linux-kernel - Re: [PATCH] tools/bpf:Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3c16c68-f6ff-47fd-b074-f42b2dad3b57@kernel.org>
Date: Wed, 24 Jul 2024 09:48:55 +0100
From: Quentin Monnet <qmo@...nel.org>
To: Zhu Jun <zhujun2@...s.chinamobile.com>
Cc: ast@...nel.org, daniel@...earbox.net, martin.lau@...ux.dev,
 eddyz87@...il.com, song@...nel.org, yonghong.song@...ux.dev,
 john.fastabend@...il.com, kpsingh@...nel.org, sdf@...ichev.me,
 haoluo@...gle.com, bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/bpf:Fix the wrong format specifier

2024-07-23 23:42 UTC-0700 ~ Zhu Jun <zhujun2@...s.chinamobile.com>
> The unsigned int should use "%u" instead of "%d".
> 
> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>
> ---
>  tools/bpf/bpftool/xlated_dumper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/bpf/bpftool/xlated_dumper.c b/tools/bpf/bpftool/xlated_dumper.c
> index 567f56dfd9f1..3efa639434be 100644
> --- a/tools/bpf/bpftool/xlated_dumper.c
> +++ b/tools/bpf/bpftool/xlated_dumper.c
> @@ -349,7 +349,7 @@ void dump_xlated_plain(struct dump_data *dd, void *buf, unsigned int len,
>  
>  		double_insn = insn[i].code == (BPF_LD | BPF_IMM | BPF_DW);
>  
> -		printf("% 4d: ", i);
> +		printf("% 4u: ", i);


Thanks! But did you try to compile this? It produces a warning:

	xlated_dumper.c: In function ‘dump_xlated_plain’:
	xlated_dumper.c:352:28: warning: ' ' flag used with ‘%u’ gnu_printf format [-Wformat=]
	  352 |                 printf("% 4u: ", i);
	      |                            ^

Please fix it.

Quentin