linux-kernel - Re: [PATCH] kbuild: Fix broken "make binrpm-pkg"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+icZUW0nKvn-TPaw_81Xm6nxFM3KXbh4=VnpgHX7OhA_RCM9g@mail.gmail.com>
Date: Wed, 24 Jul 2024 15:03:26 +0200
From: Sedat Dilek <sedat.dilek@...il.com>
To: Juergen Gross <jgross@...e.com>
Cc: linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org, 
	Masahiro Yamada <masahiroy@...nel.org>, Nathan Chancellor <nathan@...nel.org>, 
	Nicolas Schier <nicolas@...sle.eu>
Subject: Re: [PATCH] kbuild: Fix broken "make binrpm-pkg"

On Wed, Jul 24, 2024 at 2:59 PM Juergen Gross <jgross@...e.com> wrote:
>
> Due to a typo "make binrpm-pkg" isn't working when using e.g. german
> locale. rpmbuild will tell me:
>
>   error: bad date in %changelog: Mi Jul 24 2024 Juergen Gross <jgross@...e.com>
>
> Reason is that setting "LC_ALL=C" must not be followed by a semicolon
> in order to affect the following "date" command.
>
> Fixes: 301c10908e42 ("kbuild: rpm-pkg: introduce a simple changelog section for kernel.spec")
> Signed-off-by: Juergen Gross <jgross@...e.com>
> ---
>  scripts/package/mkspec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/package/mkspec b/scripts/package/mkspec
> index ead54d67a024..4dc1466dfc81 100755
> --- a/scripts/package/mkspec
> +++ b/scripts/package/mkspec
> @@ -50,6 +50,6 @@ fi
>  cat << EOF
>
>  %changelog
> -* $(LC_ALL=C; date +'%a %b %d %Y') ${name} <${email}>
> +* $(LC_ALL=C date +'%a %b %d %Y') ${name} <${email}>
>  - Custom built Linux kernel.
>  EOF
> --
> 2.43.0
>
>

Fixed in kbuild.git#fixes

https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/log/?h=fixes
https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/?h=fixes&id=ba6c664081afd18da86ac49cb22ceb266f89a561

-Sedat-