linux-kernel - Re: [PATCH v2] exfat: check disk status during buffer write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqD8dWFG5uxmJ6yn@infradead.org>
Date: Wed, 24 Jul 2024 06:07:01 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Dongliang Cui <dongliang.cui@...soc.com>
Cc: linkinjeon@...nel.org, sj1557.seo@...sung.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	niuzhiguo84@...il.com, hao_hao.wang@...soc.com, ke.wang@...soc.com,
	cuidongliang390@...il.com, Zhiguo Niu <zhiguo.niu@...soc.com>
Subject: Re: [PATCH v2] exfat: check disk status during buffer write

> +static int exfat_block_device_ejected(struct super_block *sb)
> +{
> +	struct backing_dev_info *bdi = sb->s_bdi;
> +
> +	return bdi->dev == NULL;
> +}

NAK, file systems have no business looking at this.  What you probably
really want is to implement the ->shutdown method for exfat so it gets
called on device removal.