linux-kernel - RE: [PATCH v2] exfat: check disk status during buffer write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17d6401dade58$0287e640$0797b2c0$@samsung.com>
Date: Thu, 25 Jul 2024 15:00:54 +0900
From: "Sungjong Seo" <sj1557.seo@...sung.com>
To: "'Christoph Hellwig'" <hch@...radead.org>, "'Dongliang Cui'"
	<dongliang.cui@...soc.com>
Cc: <linkinjeon@...nel.org>, <linux-fsdevel@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <niuzhiguo84@...il.com>,
	<hao_hao.wang@...soc.com>, <ke.wang@...soc.com>,
	<cuidongliang390@...il.com>, "'Zhiguo Niu'" <zhiguo.niu@...soc.com>,
	<sj1557.seo@...sung.com>
Subject: RE: [PATCH v2] exfat: check disk status during buffer write

> > +static int exfat_block_device_ejected(struct super_block *sb)
> > +{
> > +	struct backing_dev_info *bdi = sb->s_bdi;
> > +
> > +	return bdi->dev == NULL;
> > +}
> 
> NAK, file systems have no business looking at this.  What you probably
> really want is to implement the ->shutdown method for exfat so it gets
> called on device removal.

Oh! Thank you for your additional comments. I completely missed this part.
I agree with what you said. Implementing ->shutdown seems to be the
right decision.