linux-kernel - Re: [PATCH v2] exfat: check disk status during buffer write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPqOJe1xp-9snhvz7x+K6-wstLntNLdaYb9X7sLAzrP1EEzYbQ@mail.gmail.com>
Date: Fri, 26 Jul 2024 14:18:07 +0800
From: dongliang cui <cuidongliang390@...il.com>
To: Sungjong Seo <sj1557.seo@...sung.com>
Cc: Christoph Hellwig <hch@...radead.org>, Dongliang Cui <dongliang.cui@...soc.com>, linkinjeon@...nel.org, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	niuzhiguo84@...il.com, hao_hao.wang@...soc.com, ke.wang@...soc.com, 
	Zhiguo Niu <zhiguo.niu@...soc.com>
Subject: Re: [PATCH v2] exfat: check disk status during buffer write

On Thu, Jul 25, 2024 at 2:00 PM Sungjong Seo <sj1557.seo@...sung.com> wrote:
>
> > > +static int exfat_block_device_ejected(struct super_block *sb)
> > > +{
> > > +   struct backing_dev_info *bdi = sb->s_bdi;
> > > +
> > > +   return bdi->dev == NULL;
> > > +}
> >
> > NAK, file systems have no business looking at this.  What you probably
> > really want is to implement the ->shutdown method for exfat so it gets
> > called on device removal.
>
> Oh! Thank you for your additional comments. I completely missed this part.
> I agree with what you said. Implementing ->shutdown seems to be the
> right decision.
>
Thank you for your suggestions. I'll test it out this way.