linux-kernel - Re: [PATCH] checkpatch: filter null file for dt-binding check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANXhq0o8JnG6G71hhvwbmuc73j1XXit3UD_Kppdo8apEDzSZWQ@mail.gmail.com>
Date: Thu, 25 Jul 2024 14:00:35 +0800
From: Zong Li <zong.li@...ive.com>
To: apw@...onical.com, joe@...ches.com, dwaipayanray1@...il.com, 
	lukas.bulwahn@...il.com, robh@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: filter null file for dt-binding check

On Wed, Jun 19, 2024 at 2:17 PM Zong Li <zong.li@...ive.com> wrote:
>
> When removing a dt-bindings, checkpatch will catch the 'dev/null' file,
> and think there is a non-dt-binding file. It causes fail because
> /dev/null is not a dt-bindings
>
> Signed-off-by: Zong Li <zong.li@...ive.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2b812210b412..ac59a48162d2 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2896,7 +2896,7 @@ sub process {
>                         }
>                         $checklicenseline = 1;
>
> -                       if ($realfile !~ /^MAINTAINERS/) {
> +                       if (($realfile !~ /^MAINTAINERS/) && ($realfile !~ /^dev\/null$/)) {
>                                 my $last_binding_patch = $is_binding_patch;
>
>                                 $is_binding_patch = () = $realfile =~ m@^(?:Documentation/devicetree/|include/dt-bindings/)@;
> --
> 2.17.1
>

Hi all,
I was wondering if this patch makes sense to you? Thanks