[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20a8ad37-f6ce-4342-a2f7-bf3495dfeb69@kernel.org>
Date: Wed, 24 Jul 2024 15:16:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jianping.Shen@...bosch.com, jic23@...nel.org, lars@...afoo.de,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
dima.fedrau@...il.com, marcelo.schmitt1@...il.com,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Christian.Lorenz3@...bosch.com,
Ulrike.Frauendorf@...bosch.com, Kai.Dolde@...bosch.com
Subject: Re: [PATCH] dt-bindings: iio: imu: SMI240: add bosch,smi240.yaml
On 24/07/2024 14:51, Jianping.Shen@...bosch.com wrote:
> From: "Shen Jianping (ME-SE/EAD2)" <she2rt@...C-0008DVM.rt.de.bosch.com>
>
> dt-bindings: iio: imu: SMI240: add bosch,smi240.yaml
Something got corrupted here.
Anyway, please send bindings with driver in the same patchset.
Limited review follows:
> Signed-off-by: Shen Jianping (ME-SE/EAD2) <she2rt@...C-0008DVM.rt.de.bosch.com>
> ---
Missing changelog. That's v2, not v1? Provide changelog under --- and
version your patches correctly. b4 does it for you...
> .../bindings/iio/imu/bosch,smi240.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
> new file mode 100644
> index 00000000000..5e89d85d867
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/imu/bosch,smi240.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bosch SMI240 IMU
> +
> +maintainers:
> + - Jianping Shen <Jianping.Shen@...bosch.com>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + The SMI240 is a combined three axis angular rate and three axis acceleration sensor module
> + with a measurement range of +/-300°/s and up to 16g. SMI240 does not support interrupt.
> + https://www.bosch-semiconductors.com/mems-sensors/highly-automated-driving/smi240/
This does not look like wrapped according to Linux Coding Style. See
Coding Style, so 80.
> +
> +properties:
> + compatible:
> + const: bosch,smi240
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply:
> + description: provide VDD power to the sensor.
> +
> + vddio-supply:
> + description: provide VDD IO power to the sensor.
> +
> +required:
> + - compatible
> + - reg
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + spi@0 {
That's not a SPI controller. Your description suggests "imu".
Best regards,
Krzysztof
Powered by blists - more mailing lists