| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID:
<AM8PR10MB47219903C83BA4F0AFE2DAA3CDAA2@AM8PR10MB4721.EURPRD10.PROD.OUTLOOK.COM>
Date: Wed, 24 Jul 2024 14:19:25 +0000
From: "Shen Jianping (ME-SE/EAD2)" <Jianping.Shen@...bosch.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "jic23@...nel.org"
<jic23@...nel.org>, "lars@...afoo.de" <lars@...afoo.de>, "robh@...nel.org"
<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>, "dima.fedrau@...il.com"
<dima.fedrau@...il.com>, "marcelo.schmitt1@...il.com"
<marcelo.schmitt1@...il.com>, "linux-iio@...r.kernel.org"
<linux-iio@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "Lorenz Christian (ME-SE/EAD2)"
<Christian.Lorenz3@...bosch.com>, "Frauendorf Ulrike (ME/PJ-SW3)"
<Ulrike.Frauendorf@...bosch.com>, "Dolde Kai (ME-SE/PAE-A3)"
<Kai.Dolde@...bosch.com>
Subject: RE: [PATCH] dt-bindings: iio: imu: SMI240: add bosch,smi240.yaml
Anyway, please send bindings with driver in the same patchset.
-> It's fine for us. Nevertheless according to the Devicetree (DT) binding submitting rules 1.1
" The Documentation/ and include/dt-bindings/ portion of the patch should be a separate patch." See -> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Shall we still put the binding and driver in the same patch ?
Mit freundlichen Grüßen / Best regards
Jianping Shen
Mobility Electronics - Sensors, Engineering Advanced Development - MEMS Solutions Software (ME-SE/EAD2)
Robert Bosch GmbH | Postfach 13 42 | 72703 Reutlingen | GERMANY | www.bosch.com
Tel. +49 7121 35-37749 | Telefax +49 711 811-509378 | Jianping.Shen@...bosch.com
Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart, HRB 14000;
Aufsichtsratsvorsitzender: Prof. Dr. Stefan Asenkerschbaumer;
Geschäftsführung: Dr. Stefan Hartung, Dr. Christian Fischer, Dr. Markus Forschner,
Stefan Grosch, Dr. Markus Heyn, Dr. Frank Meyer, Dr. Tanja Rückert
-----Original Message-----
From: Krzysztof Kozlowski <krzk@...nel.org>
Sent: Wednesday, July 24, 2024 3:17 PM
To: Shen Jianping (ME-SE/EAD2) <Jianping.Shen@...bosch.com>; jic23@...nel.org; lars@...afoo.de; robh@...nel.org; krzk+dt@...nel.org; conor+dt@...nel.org; dima.fedrau@...il.com; marcelo.schmitt1@...il.com; linux-iio@...r.kernel.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; Lorenz Christian (ME-SE/EAD2) <Christian.Lorenz3@...bosch.com>; Frauendorf Ulrike (ME/PJ-SW3) <Ulrike.Frauendorf@...bosch.com>; Dolde Kai (ME-SE/PAE-A3) <Kai.Dolde@...bosch.com>
Subject: Re: [PATCH] dt-bindings: iio: imu: SMI240: add bosch,smi240.yaml
On 24/07/2024 14:51, Jianping.Shen@...bosch.com wrote:
> From: "Shen Jianping (ME-SE/EAD2)"
> <she2rt@...C-0008DVM.rt.de.bosch.com>
>
> dt-bindings: iio: imu: SMI240: add bosch,smi240.yaml
Something got corrupted here.
Anyway, please send bindings with driver in the same patchset.
Limited review follows:
> Signed-off-by: Shen Jianping (ME-SE/EAD2)
> <she2rt@...C-0008DVM.rt.de.bosch.com>
> ---
Missing changelog. That's v2, not v1? Provide changelog under --- and version your patches correctly. b4 does it for you...
> .../bindings/iio/imu/bosch,smi240.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
> b/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
> new file mode 100644
> index 00000000000..5e89d85d867
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> +---
> +$id:
> +https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> +cetree.org%2Fschemas%2Fiio%2Fimu%2Fbosch%2Csmi240.yaml%23&data=05%7C0
> +2%7CJianping.Shen%40de.bosch.com%7Ce4bd3cadbf5f4b17bf7308dcabe2e9b6%7
> +C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638574238283264004%7CUnkn
> +own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWw
> +iLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=gbcSKWPDSDT0qTWo5L%2FUYxlQDunqNl2l
> +L7JAxwHhNJY%3D&reserved=0
> +$schema:
> +https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C02%7CJianping.Shen
> +%40de.bosch.com%7Ce4bd3cadbf5f4b17bf7308dcabe2e9b6%7C0ae51e1907c84e4b
> +bb6d648ee58410f4%7C0%7C0%7C638574238283281959%7CUnknown%7CTWFpbGZsb3d
> +8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> +C0%7C%7C%7C&sdata=kW25MDdZz9c3ePA%2BUrGXSWsBWlDxb6UAKjOeLSnFEXU%3D&re
> +served=0
> +
> +title: Bosch SMI240 IMU
> +
> +maintainers:
> + - Jianping Shen <Jianping.Shen@...bosch.com>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + The SMI240 is a combined three axis angular rate and three axis
> + acceleration sensor module with a measurement range of +/-300°/s and up to 16g. SMI240 does not support interrupt.
> +
> + https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
> + w.bosch-semiconductors.com%2Fmems-sensors%2Fhighly-automated-driving
> + %2Fsmi240%2F&data=05%7C02%7CJianping.Shen%40de.bosch.com%7Ce4bd3cadb
> + f5f4b17bf7308dcabe2e9b6%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7
> + C638574238283298041%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ
> + IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=d2%2Bk
> + j8GzUms9o0Nbdu9QpTzZwujQnjJMp0GFp%2B5MrB0%3D&reserved=0
This does not look like wrapped according to Linux Coding Style. See Coding Style, so 80.
> +
> +properties:
> + compatible:
> + const: bosch,smi240
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply:
> + description: provide VDD power to the sensor.
> +
> + vddio-supply:
> + description: provide VDD IO power to the sensor.
> +
> +required:
> + - compatible
> + - reg
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + spi@0 {
That's not a SPI controller. Your description suggests "imu".
Best regards,
Krzysztof
Powered by blists - more mailing lists