[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240724133712.7263-1-dracodingfly@gmail.com>
Date: Wed, 24 Jul 2024 21:37:12 +0800
From: Fred Li <dracodingfly@...il.com>
To: willemdebruijn.kernel@...il.com
Cc: bpf@...r.kernel.org,
linux-kernel@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH bpf v5] bpf: Fixed segment issue when downgrade gso_size
> >
> > Linearize skb when downgrad gso_size to prevent triggering
> > the BUG_ON during segment skb as described in [1].
> >
> > v5 changes:
> > - add bpf subject prefix.
> > - adjust message to imperative mood.
> >
> > v4 changes:
> > - add fixed tag.
> >
> > v3 changes:
> > - linearize skb if having frag_list as Willem de Bruijn suggested [2].
> >
> > [1] https://lore.kernel.org/all/20240626065555.35460-2-dracodingfly@gmail.com/
> > [2] https://lore.kernel.org/all/668d5cf1ec330_1c18c32947@willemb.c.googlers.com.notmuch/
> >
> > Fixes: 2be7e212d541 ("bpf: add bpf_skb_adjust_room helper")
> > Signed-off-by: Fred Li <dracodingfly@...il.com>
>
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
>
> My comments were informational, for a next patch if any, really. v4
> was fine. v5 is too.
Thanks for your advise.
Fred Li
Powered by blists - more mailing lists