linux-kernel - Re: [PATCH bpf v5] bpf: Fixed segment issue when downgrade gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc7f6b4a-0474-99d3-ff38-139712b4e8f4@iogearbox.net>
Date: Thu, 25 Jul 2024 12:09:07 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Fred Li <dracodingfly@...il.com>, willemdebruijn.kernel@...il.com
Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf v5] bpf: Fixed segment issue when downgrade gso_size

On 7/24/24 3:37 PM, Fred Li wrote:
>>>
>>> Linearize skb when downgrad gso_size to prevent triggering
>>> the BUG_ON during segment skb as described in [1].
>>>
>>> v5 changes:
>>>   - add bpf subject prefix.
>>>   - adjust message to imperative mood.
>>>
>>> v4 changes:
>>>   - add fixed tag.
>>>
>>> v3 changes:
>>>   - linearize skb if having frag_list as Willem de Bruijn suggested [2].
>>>
>>> [1] https://lore.kernel.org/all/20240626065555.35460-2-dracodingfly@gmail.com/
>>> [2] https://lore.kernel.org/all/668d5cf1ec330_1c18c32947@willemb.c.googlers.com.notmuch/
>>>
>>> Fixes: 2be7e212d541 ("bpf: add bpf_skb_adjust_room helper")
>>> Signed-off-by: Fred Li <dracodingfly@...il.com>
>>
>> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
>>
>> My comments were informational, for a next patch if any, really. v4
>> was fine. v5 is too.
> 
> Thanks for your advise.
> 
> Fred Li

lgtm, I slightly improved wording & applied, thanks!