[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ee3b9800-4649-4e8a-af67-80713e76b79d@alliedtelesis.co.nz>
Date: Thu, 25 Jul 2024 21:02:28 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Guenter Roeck <linux@...ck-us.net>
CC: "jdelvare@...e.com" <jdelvare@...e.com>, "robh@...nel.org"
<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>, "ukleinek@...nel.org"
<ukleinek@...nel.org>, "linux-hwmon@...r.kernel.org"
<linux-hwmon@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "linux-pwm@...r.kernel.org"
<linux-pwm@...r.kernel.org>
Subject: Re: [PATCH v7 3/3] hwmon: (adt7475) Add support for configuring
initial PWM state
On 26/07/24 02:09, Guenter Roeck wrote:
> On Tue, Jul 23, 2024 at 10:17:37AM +1200, Chris Packham wrote:
>> By default the PWM duty cycle in hardware is 100%. On some systems this
>> can cause unwanted fan noise. Add the ability to specify the fan
>> connections and initial state of the PWMs via device properties.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> CHECK: Blank lines aren't necessary before a close brace '}'
> #207: FILE: drivers/hwmon/adt7475.c:1734:
> +
> +}
>
> Never mind, applied after fixing the above.
Hmm, odd checkpatch.pl doesn't complain for me
$ ./scripts/checkpatch.pl
patches/adt-init-duty/v7/v7-0003-hwmon-adt7475-Add-support-for-configuring-initial.patch
total: 0 errors, 0 warnings, 149 lines checked
patches/adt-init-duty/v7/v7-0003-hwmon-adt7475-Add-support-for-configuring-initial.patch
has no obvious style problems and is ready for submission.
>
> Thanks,
> Guenter
Powered by blists - more mailing lists