linux-kernel - Re: [PATCH] irqchip: LAN966X_OIC should depend on SOC_LAN966 || MFD_LAN966X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240725092757.2d062719@bootlin.com>
Date: Thu, 25 Jul 2024 09:27:57 +0200
From: Herve Codina <herve.codina@...tlin.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: LAN966X_OIC should depend on SOC_LAN966 ||
 MFD_LAN966X_PCI

Hi Geert,

On Tue, 23 Jul 2024 09:17:53 +0200
Geert Uytterhoeven <geert+renesas@...der.be> wrote:

> The Microchip LAN966x outband interrupt controller is only present on
> Microchip LAN966x SoCs.  However, when used as a PCI endpoint, all
> peripherals of the LAN966x SoC can be accessed by the PCI host.  Hence
> add dependencies on SOC_LAN966 and MFD_LAN966X_PCI, to prevent asking
> the user about this driver when configuring a kernel without Microchip
> LAN966x SoC and PCIe support.

I would expect a make olddefconfig silently disable LAN966X_OIC.
This is not the case ?

> 
> Fixes: 3e3a7b35332924c8 ("irqchip: Add support for LAN966x OIC")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> The patch defining MFD_LAN966X_PCI has not been accepted yet.
> Hence my initial thought was to add a dependency on PCI instead, but
> that wouldn't make much sense, as the OIC driver cannot be used without
> the MFD driver anyway.  Alternatively, the MFD_LAN966X_PCI dependency
> could be dropped for now, requiring a follow-up patch later.
> 
> "[PATCH v2 18/19] mfd: Add support for LAN966x PCI device"
> https://lore.kernel.org/all/20240527161450.326615-19-herve.codina@bootlin.com/
> ---
>  drivers/irqchip/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index bac1f0cb26e67a2b..b8d5ca3183824c93 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -171,6 +171,7 @@ config IXP4XX_IRQ
>  
>  config LAN966X_OIC
>  	tristate "Microchip LAN966x OIC Support"
> +	depends on SOC_LAN966 || MFD_LAN966X_PCI || COMPILE_TEST
>  	select GENERIC_IRQ_CHIP
>  	select IRQ_DOMAIN
>  	help

SOC_LAN966 is used only for the SOC mode of the LAN966x.
In that case, the LAN966x OIC driver is not used. Indeed, this
driver is used only in LAN966x PCI endpoint mode.

depends on MFD_LAN966X_PCI is indeed correct but, as you mentioned
it, patch defining MFD_LAN966X_PCI has not been accepter yet and
MFD_LAN966X_PCI is probably going to be renamed (the driver is
going to move from drivers/mfd to drivers/misc).


Best regards,
Hervé