linux-kernel - Re: [PATCH v2 0/2] sched/deadline: fixes and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqH-1o9pc062F-hG@jlelli-thinkpadt14gen4.remote.csb>
Date: Thu, 25 Jul 2024 09:29:26 +0200
From: Juri Lelli <juri.lelli@...hat.com>
To: Wander Lairson Costa <wander@...hat.com>
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	"open list:SCHEDULER" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] sched/deadline: fixes and improvements

Hi Wander,

On 24/07/24 11:22, Wander Lairson Costa wrote:
> Hello,
> 
> This patch series addresses specific issues and improvements within
> the scheduler's deadline (DL) class. The patches aim to fix warnings,
> remove redundant checks, and consolidate timer cancellation logic for
> better consistency and code quality.
> 
> Patch 1: Fix warning in migrate_enable for boosted tasks
> 
> Fix a warning caused by unnecessary calls to setup_new_dl_entity for
> boosted tasks during CPU migate_enable calls.
> 
> Patch 2: sched/deadline: Consolidate Timer Cancellation
> 
> Consolidate timer cancellation logic into dedicated functions,
> ensuring consistent behavior and reducing code duplication.
> 
> Changelog
> ---------
> 
> v2:
> * Drop patch to remove the redundant WARN_ON call.
> * Change the "Fixes" tag in the patch 1.
> * Change function names in the patch 2.
> 
> Wander Lairson Costa (2):
>   sched/deadline: Fix warning in migrate_enable for boosted tasks
>   sched/deadline: Consolidate Timer Cancellation
> 
>  kernel/sched/deadline.c | 45 ++++++++++++++++++++++++++---------------
>  1 file changed, 29 insertions(+), 16 deletions(-)

Looks good to me now.

Acked-by: Juri Lelli <juri.lelli@...hat.com>

Thanks!
Juri