linux-kernel - Re: [PATCH] mm: huge_memory: don't start_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4wmkgNjdjReL55feWFgVonymyS4yyi3426eY0hpTWYAEw@mail.gmail.com>
Date: Fri, 26 Jul 2024 23:00:37 +1200
From: Barry Song <21cnbao@...il.com>
To: Ryan Roberts <ryan.roberts@....com>
Cc: David Hildenbrand <david@...hat.com>, akpm@...ux-foundation.org, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, Barry Song <v-songbaohua@...o.com>, 
	Lance Yang <ioworker0@...il.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>, 
	Yang Shi <shy828301@...il.com>, Zi Yan <ziy@...dia.com>
Subject: Re: [PATCH] mm: huge_memory: don't start_stop_khugepaged for non-PMD THP

On Fri, Jul 26, 2024 at 10:45 PM Ryan Roberts <ryan.roberts@....com> wrote:
>
> On 26/07/2024 11:04, Barry Song wrote:
> > On Fri, Jul 26, 2024 at 9:48 PM David Hildenbrand <david@...hat.com> wrote:
> >>
> >> On 26.07.24 11:43, Ryan Roberts wrote:
> >>> On 26/07/2024 09:28, Barry Song wrote:
> >>>> From: Barry Song <v-songbaohua@...o.com>
> >>>>
> >>>> khugepaged will be automatically started when PMD-sized THP is enabled
> >>>> (either of the per-size anon control or the top-level control are set
> >>>> to "always" or "madvise"), and it'll be automatically shutdown when
> >>>> PMD-sized THP is disabled (when both the per-size anon control and the
> >>>> top-level control are "never").
> >>>>
> >>>> It seems unnecessary to call start_stop_khugepaged() for non-PMD THP,
> >>>> as it would only waste CPU time.
> >>>>
> >>>> Cc: Lance Yang <ioworker0@...il.com>
> >>>> Cc: Ryan Roberts <ryan.roberts@....com>
> >>>> Cc: Baolin Wang <baolin.wang@...ux.alibaba.com>
> >>>> Cc: David Hildenbrand <david@...hat.com>
> >>>> Cc: Yang Shi <shy828301@...il.com>
> >>>> Cc: Zi Yan <ziy@...dia.com>
> >>>> Signed-off-by: Barry Song <v-songbaohua@...o.com>
> >>>> ---
> >>>>   mm/huge_memory.c | 2 +-
> >>>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> >>>> index 41460847988c..bd365e35acf7 100644
> >>>> --- a/mm/huge_memory.c
> >>>> +++ b/mm/huge_memory.c
> >>>> @@ -514,7 +514,7 @@ static ssize_t thpsize_enabled_store(struct kobject *kobj,
> >>>>      } else
> >>>>              ret = -EINVAL;
> >>>>
> >>>> -    if (ret > 0) {
> >>>> +    if (ret > 0 && order == HPAGE_PMD_ORDER) {
> >>>>              int err;
> >>>>
> >>>>              err = start_stop_khugepaged();
> >>>
> >>> Personally I see this as a bit of a layering violation; its
> >>> start_stop_khugepaged() that should decide the policy for when to start and stop
> >>> the daemon. thpsize_enabled_store() should just be calling
> >>> start_stop_khugepaged() to notify that something potentially pertinent to the a
> >>> policy decision has changed.
> >>
> >
> > My impression is that it slightly deviates from the huge page documentation in
> > Documentation/admin-guide/mm/transhuge.rst.
> >
> > khugepaged will be automatically started when PMD-sized THP is enabled
> > (either of the per-size anon control or the top-level control are set
> > to "always" or "madvise"), and it'll be automatically shutdown when
> > PMD-sized THP is disabled (when both the per-size anon control and the
> > top-level control are "never").
>
> But start_stop_khugepaged() doesn't unconditionally start khugepaged, it takes
> action based on hugepage_pmd_enabled() which only returns true if there are any
> pmd sized THP enabled (currently looking at anon and file, but should also look
> at shmem in future; that's a known bug that's been there forever). So I don't
> think it is inconsistent with the documentation?

My point is that, as a code reader, if non-PMD sizes are never
involved with khugepaged,
we can proceed without needing to check the lower-layer code.
otherwise it is a bit
confusing, especially since start_stop_khugepaged() unconditionally calls
set_recommended_min_free_kbytes() for all sizes, regardless of whether
they are PMD.

However, I agree with your point that if non-PMD sizes are eventually managed by
khugepaged, then this approach is flawed. This is the downside of this change.

>
> >
> > non-PMD size is not involved in khugepaged, but I agree the policy might change
> > in the future.
> >
> >> Agreed, skimming the subject I was under the impression that we would be
> >> fixing something here.
> >
> > working on another swapin_enabled and reviewing the enabled source code.
> > I don't need this startstop for all sizes in that case, so I made a
> > quick adjustment
> > to this part as well. If neither of you likes it, that's fine with me :-)
> >
> >>
> >> --
> >> Cheers,
> >>
> >> David / dhildenb
> >>

Thanks
Barry