linux-kernel - Re: [PATCH v10 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <624be618-1a1a-422c-85e9-be3e1d182adf@web.de>
Date: Sun, 28 Jul 2024 11:40:12 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Keguang Zhang <keguang.zhang@...il.com>, dmaengine@...r.kernel.org,
 devicetree@...r.kernel.org, linux-mips@...r.kernel.org,
 Conor Dooley <conor+dt@...nel.org>, Jiaxun Yang <jiaxun.yang@...goat.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 Vinod Koul <vkoul@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA
 driver

> This patch adds …

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n94


…
> +++ b/drivers/dma/loongson1-apb-dma.c
> @@ -0,0 +1,675 @@
…
> +static int ls1x_dma_resume(struct dma_chan *dchan)
> +{
…
> +	spin_lock_irqsave(&chan->vchan.lock, flags);
> +	ret = ls1x_dma_start(chan, &chan->curr_lli->phys);
> +	spin_unlock_irqrestore(&chan->vchan.lock, flags);
> +
> +	return ret;
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&chan->vchan.lock);”?
https://elixir.bootlin.com/linux/v6.10.2/source/include/linux/spinlock.h#L574

Regards,
Markus