linux-kernel - Re: [PATCH v10 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJhJPsUb4KibbFtPJ3-byrsB2Yv82eGczkcysNrJjJ7WiYYhxQ@mail.gmail.com>
Date: Mon, 29 Jul 2024 20:55:24 +0800
From: Keguang Zhang <keguang.zhang@...il.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: dmaengine@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-mips@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, 
	Jiaxun Yang <jiaxun.yang@...goat.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Rob Herring <robh@...nel.org>, Vinod Koul <vkoul@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver

On Sun, Jul 28, 2024 at 5:40 PM Markus Elfring <Markus.Elfring@....de> wrote:
>
> > This patch adds …
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n94
>
Will drop "This patch".
>
> …
> > +++ b/drivers/dma/loongson1-apb-dma.c
> > @@ -0,0 +1,675 @@
> …
> > +static int ls1x_dma_resume(struct dma_chan *dchan)
> > +{
> …
> > +     spin_lock_irqsave(&chan->vchan.lock, flags);
> > +     ret = ls1x_dma_start(chan, &chan->curr_lli->phys);
> > +     spin_unlock_irqrestore(&chan->vchan.lock, flags);
> > +
> > +     return ret;
> > +}
> …
>
> Under which circumstances would you become interested to apply a statement
> like “guard(spinlock_irqsave)(&chan->vchan.lock);”?
> https://elixir.bootlin.com/linux/v6.10.2/source/include/linux/spinlock.h#L574
>
Will switch to guard() and scoped_guard().
Thanks!

> Regards,
> Markus



-- 
Best regards,

Keguang Zhang