linux-kernel - Re: [PATCH] crypto: iaa - Fix potential use after free bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d11ad678099ccce94eacf721c8d06a38129ce2d3.camel@linux.intel.com>
Date: Mon, 29 Jul 2024 11:40:18 -0500
From: Tom Zanussi <tom.zanussi@...ux.intel.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller"
	 <davem@...emloft.net>, linux-crypto@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] crypto: iaa - Fix potential use after free bug

Hi Dan,

On Wed, 2024-07-24 at 11:09 -0500, Dan Carpenter wrote:
> The free_device_compression_mode(iaa_device, device_mode) function
> frees
> "device_mode" but it iss passed to iaa_compression_modes[i]->free() a
> few
> lines later resulting in a use after free.
> 
> The good news is that, so far as I can tell, nothing implements the
> ->free() function and the use after free happens in dead code.  But,
> with
> this fix, when something does implement it, we'll be ready.  :)
> 

Good catch, thanks for fixing this.

Reviewed-by: Tom Zanussi <tom.zanussi@...ux.intel.com>


> Fixes: b190447e0fa3 ("crypto: iaa - Add compression mode management
> along with fixed mode")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/crypto/intel/iaa/iaa_crypto_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c
> b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> index e810d286ee8c..237f87000070 100644
> --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c
> +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> @@ -495,10 +495,10 @@ static void
> remove_device_compression_modes(struct iaa_device *iaa_device)
>                 if (!device_mode)
>                         continue;
>  
> -               free_device_compression_mode(iaa_device,
> device_mode);
> -               iaa_device->compression_modes[i] = NULL;
>                 if (iaa_compression_modes[i]->free)
>                         iaa_compression_modes[i]->free(device_mode);
> +               free_device_compression_mode(iaa_device,
> device_mode);
> +               iaa_device->compression_modes[i] = NULL;
>         }
>  }
>