linux-kernel - Re: [PATCH] crypto: iaa - Fix potential use after free bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZqzcMBtKQDI8QHUc@gondor.apana.org.au>
Date: Fri, 2 Aug 2024 21:16:32 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Tom Zanussi <tom.zanussi@...ux.intel.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] crypto: iaa - Fix potential use after free bug

On Wed, Jul 24, 2024 at 11:09:43AM -0500, Dan Carpenter wrote:
> The free_device_compression_mode(iaa_device, device_mode) function frees
> "device_mode" but it iss passed to iaa_compression_modes[i]->free() a few
> lines later resulting in a use after free.
> 
> The good news is that, so far as I can tell, nothing implements the
> ->free() function and the use after free happens in dead code.  But, with
> this fix, when something does implement it, we'll be ready.  :)
> 
> Fixes: b190447e0fa3 ("crypto: iaa - Add compression mode management along with fixed mode")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/crypto/intel/iaa/iaa_crypto_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt