linux-kernel - Re: [PATCH] clang-format: Update with v6.11-rc1's `for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65faaf53-ad53-4b1c-9ccf-2ed9886d4f7a@gmail.com>
Date: Tue, 30 Jul 2024 00:42:59 +0200
From: Javier Carrasco <javier.carrasco.cruz@...il.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling
 <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] clang-format: Update with v6.11-rc1's `for_each` macro
 list

On 29/07/2024 23:55, Miguel Ojeda wrote:
> On Mon, Jul 29, 2024 at 11:39 PM Javier Carrasco
> <javier.carrasco.cruz@...il.com> wrote:
>>
>> A quick test threw 326 extra macros that are defined in internal headers
>> under drivers/ and arch/. Including internal headers would remove the
>> need to update the list if a macro is moved from inlcude/ to an internal
>> header, but the list will need to be updated much more often.
> 
> There would be more changes in each iteration (which is why we avoided
> scanning everything in the beginning), but currently it is
> best-effort. If nowadays there are subsystems that want to start
> considering soft-enforcing `clang-format` and that is why they need
> them updated as soon as possible, then we should discuss other
> alternatives (please let me know if that is the case!).
> 
> For instance, we could try to somehow divide the list into individual
> subsystems, so that they control it and can perform the updates at the
> same time in their commits as needed.
> 
> Anyway, for the time being, we should avoid editing the list "manually".
> 
> Cheers,
> Miguel

That is not my particular case, I just wanted to add some macros that
reside under include/ (in particular, the _scoped macros).

Given that no one came with a need for macros defined in internal
headers, I will just drop `displayid_iter_for_each` for v2.

Best regards,
Javier Carrasco