linux-kernel - Re: [PATCH] tracing: Use refcount for trace_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240729190241.47e52c05@rorschach.local.home>
Date: Mon, 29 Jul 2024 19:02:41 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Linux trace kernel
 <linux-trace-kernel@...r.kernel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH] tracing: Use refcount for trace_event_file reference
 counter

On Mon, 29 Jul 2024 23:49:24 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> On Fri, 26 Jul 2024 14:42:08 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > From: Steven Rostedt <rostedt@...dmis.org>
> > 
> > Instead of using an atomic counter for the trace_event_file reference
> > counter, use the refcount interface. It has various checks to make sure
> > the reference counting is correct, and will warn if it detects an error
> > (like refcount_inc() on '0').
> > 
> > Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>  
> 
> Looks good to me.
> 
> Masami Hiramatsu (Google) <mhiramat@...nel.org>

Is that an ack or a review? ;-)

-- Steve