linux-kernel - Re: [PATCH] selftests: user: remove user suite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5472489-f430-46f2-b9ef-bc625242e8d6@collabora.com>
Date: Mon, 29 Jul 2024 12:18:44 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Shuah Khan <skhan@...uxfoundation.org>, Shuah Khan <shuah@...nel.org>,
 Kees Cook <kees@...nel.org>, David Gow <davidgow@...gle.com>,
 Vitor Massaru Iha <vitor@...saru.org>
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>, kernel@...labora.com,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests: user: remove user suite

On 7/26/24 10:19 PM, Shuah Khan wrote:
> On 7/26/24 02:16, Muhammad Usama Anjum wrote:
>> On 7/25/24 7:44 PM, Shuah Khan wrote:
>>> On 7/25/24 05:08, Muhammad Usama Anjum wrote:
>>>> The user test suite has only one test, test_user_copy which loads
>>>> test_user_copy module for testing. But test_user_copy module has already
>>>> been converted to kunit (see fixes). Hence remove the entire suite.
>>>>
>>>> Fixes: cf6219ee889f ("usercopy: Convert test_user_copy to KUnit test")
>>>
>>> Remove fixes tag - this isn't a fix and we don't want this propagating
>>> to stable releases without kunit test for this.
>> The user test suite has been failing since cf6219ee889f as the test module
>> wasn't found. So this is fixing the failure of kselftest. It just causes
>> noise and may mask other failures. If you still think that fixes isn't
>> needed, I can send a new version by removing the fixes tag.
>>
> 
> In which case this information should have been part of the change log to
> make it clear this is a fix.
Sorry, I should have mentioned explicitly. Please let me know if I should
send another version for this and the other patch for acceptance [1]?

> Fixes tag should also mention the releases
> this is applicable to so this patch doesn't make it to stables releases
> without cf6219ee889f - so this test still runs.
Release tag is unnecessary as the fix can be applied easily to fixes
commit. From stable-kernel-rules:

  Note, such tagging is unnecessary if the stable team can derive the
  appropriate versions from Fixes: tags.

> 
> If you are adding Fixes tag it should mention the releases this is
> applicable to. Can you get me that information?
> 
> thanks,
> -- Shuah
> 
> 

[1]
https://lore.kernel.org/all/20240725121212.808206-1-usama.anjum@collabora.com

-- 
BR,
Muhammad Usama Anjum