linux-kernel - Re: [PATCH] media: ipu-bridge: fix ipu6 Kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c05a72dd-1821-43ba-b3b4-caa9334e4016@app.fastmail.com>
Date: Mon, 29 Jul 2024 09:24:23 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Sakari Ailus" <sakari.ailus@...ux.intel.com>,
 "Arnd Bergmann" <arnd@...nel.org>
Cc: "Bingbu Cao" <bingbu.cao@...el.com>,
 "Mauro Carvalho Chehab" <mchehab@...nel.org>,
 "Hans Verkuil" <hverkuil-cisco@...all.nl>,
 "Andreas Helbech Kleist" <andreaskleist@...il.com>,
 "Tianshu Qiu" <tian.shu.qiu@...el.com>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: ipu-bridge: fix ipu6 Kconfig dependencies

On Mon, Jul 29, 2024, at 09:03, Sakari Ailus wrote:
>> To make it consistent with the other IPU drivers as well as avoid this warning,
>> change the 'select' into 'depends on'.
>
> Thanks for the patch. I'm not sure how I managed to miss the IPU6 driver...

The driver was only adding in 6.10, so your patch was correct
at the time.

> I think we also need, besides IPU_BRIDGE, || !IPU_BRIDGE, as the IPU_BRIDGE
> has additional dependencies (I2C) compared to VIDEO_INTEL_IPU6. I'll add
> that while applying. Please let me know if you have concerns.

Makes sense, yes. I went with a hard dependency since that stays
close to the current version with the select. I tried build-testing
IPU6 now with IPU_BRIDGE=n and I2C=n/I2C=m, which works fine.

However, the testing showed that IPU6 also missed a 'select AUXILIARY_BUS',
which I had not found in randconfig testing because that usually gets
selected by one of is other 30 users.

Since you are changing my patch already, maybe you can also add
that at the same time. Thanks,

     Arnd