linux-kernel - Re: [PATCH 1/5] dt-bindings: clock: mt6765: Add missing PMIC clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dceb85da-0518-4215-9963-2d577b183021@kernel.org>
Date: Mon, 29 Jul 2024 09:36:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Arseniy Velikanov <me@...merle.xyz>, mturquette@...libre.com,
 sboyd@...nel.org, matthias.bgg@...il.com,
 angelogioacchino.delregno@...labora.com, sean.wang@...nel.org,
 linus.walleij@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, frank.li@...o.com, jiasheng@...as.ac.cn,
 mars.cheng@...iatek.com, owen.chen@...iatek.com, macpaul.lin@...iatek.com,
 zh.chen@...iatek.com, argus.lin@...iatek.com
Cc: linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: clock: mt6765: Add missing PMIC clock

On 29/07/2024 09:34, Arseniy Velikanov wrote:
> Add PWRAP clock binding and shift the following ones
> 
> Fixes: eb7beb65ac30 ("clk: mediatek: add mt6765 clock IDs")

Please describe the bug and its observable impact.

> Signed-off-by: Arseniy Velikanov <me@...merle.xyz>
> ---
>  include/dt-bindings/clock/mt6765-clk.h | 131 +++++++++++++------------
>  1 file changed, 66 insertions(+), 65 deletions(-)
> 
> diff --git a/include/dt-bindings/clock/mt6765-clk.h b/include/dt-bindings/clock/mt6765-clk.h
> index eb97e568518e..5d3a603a0d36 100644
> --- a/include/dt-bindings/clock/mt6765-clk.h
> +++ b/include/dt-bindings/clock/mt6765-clk.h
> @@ -161,71 +161,72 @@
>  #define CLK_TOP_NR_CLK			126
>  
>  /* INFRACFG */
> -#define CLK_IFR_ICUSB			0

NAK, you cannot change the bindings. Especially without bigger
description where the bug is.

Best regards,
Krzysztof