linux-kernel - Re: [PATCH 3/5] pinctrl: mediatek: mt6765: Add virtual GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f73bf4de-0795-41a6-a94a-016e85721e2e@collabora.com>
Date: Mon, 29 Jul 2024 09:46:46 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Arseniy Velikanov <me@...merle.xyz>, mturquette@...libre.com,
 sboyd@...nel.org, matthias.bgg@...il.com, sean.wang@...nel.org,
 linus.walleij@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, frank.li@...o.com, jiasheng@...as.ac.cn,
 mars.cheng@...iatek.com, owen.chen@...iatek.com, macpaul.lin@...iatek.com,
 zh.chen@...iatek.com, argus.lin@...iatek.com
Cc: linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 3/5] pinctrl: mediatek: mt6765: Add virtual GPIOs

Il 29/07/24 09:34, Arseniy Velikanov ha scritto:
> Add EINT-only virtual GPIOs as done for MT6735
> These pins are needed at least for PWRAP
> 

Those are not virtual - they do exist. For real.

I would, at this point, describe this commit as such:

pinctrl: mediatek: mt6765: Add GPIOs for PWRAP

Introduce missing additional EINT pins, used mainly for the PMIC Wrapper.


> Fixes: 477fecee7ca9 ("pinctrl: mediatek: add MT6765 pinctrl driver")

...and this is an addition, not a fix, so please remove the Fixes tag.

Cheers,
Angelo

> Signed-off-by: Arseniy Velikanov <me@...merle.xyz>
> ---
>   drivers/pinctrl/mediatek/pinctrl-mtk-mt6765.h | 66 +++++++++++++++++++
>   1 file changed, 66 insertions(+)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt6765.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt6765.h
> index 772563720461..070af420333b 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-mt6765.h
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt6765.h
> @@ -1749,6 +1749,72 @@ static struct mtk_pin_desc mtk_pins_mt6765[] = {
>   		DRV_GRP4,
>   		MTK_FUNCTION(0, "GPIO179")
>   	),
> +	MTK_PIN(
> +		180, "GPIO180",
> +		MTK_EINT_FUNCTION(0, 144),
> +		DRV_GRP4,
> +		MTK_FUNCTION(0, NULL)
> +	),
> +	MTK_PIN(
> +		181, "GPIO181",
> +		MTK_EINT_FUNCTION(0, 145),
> +		DRV_GRP4,
> +		MTK_FUNCTION(0, NULL)
> +	),
> +	MTK_PIN(
> +		182, "GPIO182",
> +		MTK_EINT_FUNCTION(0, 152),
> +		DRV_FIXED,
> +		MTK_FUNCTION(0, NULL)
> +	),
> +	MTK_PIN(
> +		183, "GPIO183",
> +		MTK_EINT_FUNCTION(0, 153),
> +		DRV_FIXED,
> +		MTK_FUNCTION(0, NULL)
> +	),
> +	MTK_PIN(
> +		184, "GPIO184",
> +		MTK_EINT_FUNCTION(0, 154),
> +		DRV_FIXED,
> +		MTK_FUNCTION(0, NULL)
> +	),
> +	MTK_PIN(
> +		185, "GPIO185",
> +		MTK_EINT_FUNCTION(0, 155),
> +		DRV_FIXED,
> +		MTK_FUNCTION(0, NULL)
> +	),
> +	MTK_PIN(
> +		186, "GPIO186",
> +		MTK_EINT_FUNCTION(0, 156),
> +		DRV_FIXED,
> +		MTK_FUNCTION(0, NULL)
> +	),
> +	MTK_PIN(
> +		187, "GPIO187",
> +		MTK_EINT_FUNCTION(0, 157),
> +		DRV_FIXED,
> +		MTK_FUNCTION(0, NULL)
> +	),
> +	MTK_PIN(
> +		188, "GPIO188",
> +		MTK_EINT_FUNCTION(0, 158),
> +		DRV_FIXED,
> +		MTK_FUNCTION(0, NULL)
> +	),
> +	MTK_PIN(
> +		189, "GPIO189",
> +		MTK_EINT_FUNCTION(0, 159),
> +		DRV_FIXED,
> +		MTK_FUNCTION(0, NULL)
> +	),
> +	MTK_PIN(
> +		190, "GPIO190",
> +		MTK_EINT_FUNCTION(0, 147),
> +		DRV_GRP4,
> +		MTK_FUNCTION(0, NULL)
> +	),
>   };
>   
>   #endif /* __PINCTRL_MTK_MT6765_H */