linux-kernel - Re: [PATCH] char: misc: add missing #ifdef CONFIG_PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <bbb597df-5bd8-487a-8b5c-9118814632e8@app.fastmail.com>
Date: Mon, 29 Jul 2024 11:42:37 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: zhangjiao2 <zhangjiao2@...s.chinamobile.com>
Cc: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] char: misc: add missing #ifdef CONFIG_PROC_FS and error checking

On Mon, Jul 29, 2024, at 09:35, zhangjiao2 wrote:
> From: Zhang Jiao <zhangjiao2@...s.chinamobile.com>
>
> Add "#ifdef CONFIG_PROC_FS" to control misc proc create 
> and give some error checking.
>
> Signed-off-by: Zhang Jiao <zhangjiao2@...s.chinamobile.com>
> ---

I don't think this is an improvement: proc_create_*() already
prints a warning about how exactly it went wrong when it does,
and it can usually just continue without it. However, failing
misc_init() is likely to prevent the system from booting.

     Arnd