linux-kernel - Re: [PATCH] char: misc: add missing #ifdef CONFIG_PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024072951-lyrically-running-d1e3@gregkh>
Date: Mon, 29 Jul 2024 11:43:40 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: zhangjiao2 <zhangjiao2@...s.chinamobile.com>
Cc: arnd@...db.de, linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] char: misc: add missing #ifdef CONFIG_PROC_FS and error
 checking

On Mon, Jul 29, 2024 at 03:35:11PM +0800, zhangjiao2 wrote:
> From: Zhang Jiao <zhangjiao2@...s.chinamobile.com>
> 
> Add "#ifdef CONFIG_PROC_FS" to control misc proc create 
> and give some error checking.
> 
> Signed-off-by: Zhang Jiao <zhangjiao2@...s.chinamobile.com>
> ---
>  drivers/char/misc.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
> index 541edc26ec89..0370d53f368a 100644
> --- a/drivers/char/misc.c
> +++ b/drivers/char/misc.c
> @@ -286,9 +286,15 @@ EXPORT_SYMBOL(misc_deregister);
>  static int __init misc_init(void)
>  {
>  	int err;
> +#ifdef CONFIG_PROC_FS

We should almost never have #ifdef in .c files, please don't do that
here either.

Also, why is this suddenly a new issue?

And, when you have "and" in a changelog text, that's a huge hint you
need to split things up into multiple patches, please do that here.

thanks,

greg k-h