lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <15796d83-2dd0-7c45-af92-4ee476043b74@amd.com>
Date: Tue, 30 Jul 2024 08:22:54 -0500
From: Tom Lendacky <thomas.lendacky@....com>
To: Pavan Kumar Paluri <papaluri@....com>, linux-kernel@...r.kernel.org
Cc: Borislav Petkov <bp@...en8.de>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Dave Hansen <dave.hansen@...ux.intel.com>,
 Ashish Kalra <ashish.kalra@....com>, Michael Roth <michael.roth@....com>,
 stable@...r.kernel.org
Subject: Re: [PATCH] x86/sev: Fix __reserved field in sev_config

On 7/29/24 13:08, Pavan Kumar Paluri wrote:
> sev_config currently has debug, ghcbs_initialized, and use_cas fields.
> However, __reserved count has not been updated. Fix this.
> 
> Fixes: 34ff65901735 ("x86/sev: Use kernel provided SVSM Calling Areas")
> Cc: stable@...r.kernel.org
> Signed-off-by: Pavan Kumar Paluri <papaluri@....com>

Reviewed-by: Tom Lendacky <thomas.lendacky@....com>

You'd think the compiler would spit out some kind of warning when this
happens, but I guess it just happily adds another u64 to the struct.

Thanks,
Tom

> ---
>  arch/x86/coco/sev/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
> index 082d61d85dfc..de1df0cb45da 100644
> --- a/arch/x86/coco/sev/core.c
> +++ b/arch/x86/coco/sev/core.c
> @@ -163,7 +163,7 @@ struct sev_config {
>  	       */
>  	      use_cas		: 1,
>  
> -	      __reserved	: 62;
> +	      __reserved	: 61;
>  };
>  
>  static struct sev_config sev_cfg __read_mostly;

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ