[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240730132300.wglmpo66n25p5crm@quack3>
Date: Tue, 30 Jul 2024 15:23:00 +0200
From: Jan Kara <jack@...e.cz>
To: Kemeng Shi <shikemeng@...weicloud.com>
Cc: tytso@....edu, jack@...e.com, linux-ext4@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] jbd2: remove dead check in journal_alloc_journal_head
On Tue 30-07-24 19:33:30, Kemeng Shi wrote:
> We will alloc journal_head with __GFP_NOFAIL anyway, test for failure
> is pointless.
>
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
Why not. Feel free to add:
Reviewed-by: Jan Kara <jack@...e.cz>
Honza
> ---
> fs/jbd2/journal.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index da5a56d700f1..b5d02de1ffff 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -2866,8 +2866,7 @@ static struct journal_head *journal_alloc_journal_head(void)
> ret = kmem_cache_zalloc(jbd2_journal_head_cache,
> GFP_NOFS | __GFP_NOFAIL);
> }
> - if (ret)
> - spin_lock_init(&ret->b_state_lock);
> + spin_lock_init(&ret->b_state_lock);
> return ret;
> }
>
> --
> 2.30.0
>
--
Jan Kara <jack@...e.com>
SUSE Labs, CR
Powered by blists - more mailing lists