linux-kernel - Re: [PATCH] workqueue: add cmdline parameter workqueue.panic_on_watchdog/max_watchdog_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqlemexVxV0LQVGR@slm.duckdns.org>
Date: Tue, 30 Jul 2024 11:43:53 -1000
From: Tejun Heo <tj@...nel.org>
To: Sangmoon Kim <sangmoon.kim@...sung.com>
Cc: youngjae24.lim@...sung.com, jordan.lim@...sung.com,
	myoungjae.kim@...sung.com, Lai Jiangshan <jiangshanlai@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] workqueue: add cmdline parameter
 workqueue.panic_on_watchdog/max_watchdog_to_panic

Hello,

On Tue, Jul 30, 2024 at 05:04:28PM +0900, Sangmoon Kim wrote:
> +static bool wq_panic_on_watchdog;
> +module_param_named(panic_on_watchdog, wq_panic_on_watchdog, bool, 0644);
> +static unsigned int wq_max_watchdog_to_panic;
> +module_param_named(max_watchdog_to_panic, wq_max_watchdog_to_panic, uint, 0644);

Can you combine the two into a single parameter? Maybe name it
wq_panic_on_stall? 0 disables. >0 indicates the number of times before
triggering panic, maybe?

Thanks.

-- 
tejun