linux-kernel - RE: [PATCH] workqueue: add cmdline parameter workqueue.panic_on_watchdog/max_watchdog_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240805023147.2984866-1-sangmoon.kim@samsung.com>
Date: Mon,  5 Aug 2024 11:31:47 +0900
From: Sangmoon Kim <sangmoon.kim@...sung.com>
To: Tejun Heo <tj@...nel.org>
Cc: jiangshanlai@...il.com, jordan.lim@...sung.com,
	linux-kernel@...r.kernel.org, myoungjae.kim@...sung.com,
	sangmoon.kim@...sung.com, youngjae24.lim@...sung.com
Subject: RE: [PATCH] workqueue: add cmdline parameter
 workqueue.panic_on_watchdog/max_watchdog_to_panic


> -----Original Message-----
> From: Tejun Heo <htejun@...il.com> On Behalf Of Tejun Heo
> Sent: Wednesday, July 31, 2024 6:44 AM
> 
> Hello,
> 
> On Tue, Jul 30, 2024 at 05:04:28PM +0900, Sangmoon Kim wrote:
> > +static bool wq_panic_on_watchdog;
> > +module_param_named(panic_on_watchdog, wq_panic_on_watchdog, bool, 0644);
> > +static unsigned int wq_max_watchdog_to_panic;
> > +module_param_named(max_watchdog_to_panic, wq_max_watchdog_to_panic, uint, 0644);
> 
> Can you combine the two into a single parameter? Maybe name it
> wq_panic_on_stall? 0 disables. >0 indicates the number of times before
> triggering panic, maybe?
> 
> Thanks.
> 
> --
> tejun

Okay. Let me do that.
Thanks for the review.

Sangmoon