linux-kernel - Re: [PATCH v2] drm/msm/dp: enable widebus on all relevant chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zqlor3Ug70d65rLT@hu-bjorande-lv.qualcomm.com>
Date: Tue, 30 Jul 2024 15:26:55 -0700
From: Bjorn Andersson <quic_bjorande@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Abhinav Kumar <quic_abhinavk@...cinc.com>,
        <freedreno@...ts.freedesktop.org>, Rob Clark <robdclark@...il.com>,
        Sean Paul
	<sean@...rly.run>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        "David
 Airlie" <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        Abel Vesa
	<abel.vesa@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        <dri-devel@...ts.freedesktop.org>, <quic_jesszhan@...cinc.com>,
        <swboyd@...omium.org>, <dianders@...omium.org>, <andersson@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drm/msm/dp: enable widebus on all relevant chipsets

On Tue, Jul 30, 2024 at 11:58:19PM +0300, Dmitry Baryshkov wrote:
> Hi Abhinav,
> 
> On Tue, 30 Jul 2024 at 22:50, Abhinav Kumar <quic_abhinavk@...cinc.com> wrote:
> >
> > Hardware document indicates that widebus is recommended on DP on all
> > MDSS chipsets starting version 5.x.x and above.
> >
> > Follow the guideline and mark widebus support on all relevant
> > chipsets for DP.
> >
> > Fixes: 766f705204a0 ("drm/msm/dp: Remove now unused connector_type from desc")
> > Fixes: 1b2d98bdd7b7 ("drm/msm/dp: Add DisplayPort controller for SM8650")
> 
> The issues are present in the following commits. Please consider using
> them instead:
> 
> Fixes: 757a2f36ab09 ("drm/msm/dp: enable widebus feature for display port")
> Fixes: 1b2d98bdd7b7 ("drm/msm/dp: Add DisplayPort controller for SM8650")
> 

But are we really fixing any bugs/issues here? While the docs do
recommend widebus, we're effectively enabling more harware/features.

Unless there's a strong reason (which I'm not confident that the commit
message entails), I think we should drop the fixes-tags and just bring
this to 6.12...

Regards,
Bjorn

> 
> > Signed-off-by: Abhinav Kumar <quic_abhinavk@...cinc.com>
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > ---
> >  drivers/gpu/drm/msm/dp/dp_display.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> -- 
> With best wishes
> Dmitry